Skip to content

Conversation

Cappybara12
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2025

CLA assistant check
All committers have signed the CLA.

@tarakaswathi-datazip
Copy link
Collaborator

@Cappybara12 can you make it similar to this w.r.t border and conatiner
Screenshot 2025-08-06 at 3 34 08 PM
star icon and color seems fine ,

@tarakaswathi-datazip
Copy link
Collaborator

when i go to some other page like http://localhost:3000/iceberg/query-engine github icon and stars are missing ,navbar should be consistent

@tarakaswathi-datazip
Copy link
Collaborator

updates needed:

  • write only one single react component for handling github stars ,remove vanilla js implementation
  • remove css (seems to be extensive) add classes if the problem is not solvable via tailwind (custom css)
  • remove html injection used
  • use inline styles wherever possible
  • dont load external scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants