feat: clear destination for iceberg/s3 #44
+2,573
−2,250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: staging to master (helm chart version v0.0.1)
fix: add write permissions for gh token (#11)
feat: add index copy step (#13)
feat: add release workflows (#17)
fix: set task queue (#20)
- Add nfsServer.external.storageClass and size parameters in values.yaml - Modify shared-storage-pvc.yaml to always create PVC with conditional storage class - Simplify _helpers.tpl sharedStoragePVC function to use consistent naming - Add validation error when storageClass is empty and NFS is disabled - Support RWX storage classes like EFS, Azure Files, GCP Filestore, etc.
- Remove PodAntiAffinity that prevented sync pods from running on same node - Allow multiple sync operations to run concurrently for better resource utilization - Keep JobID-based node affinity for resource mapping - Fix tautological condition in affinity assignment
- Add ConfigMapWatcher using client-go informers for live updates - Integrate watcher into K8sPodManager with graceful shutdown - Update pod scheduling to use live mapping instead of static config - Support debouncing (2s) for rapid ConfigMap changes - Maintain backward compatibility with existing Helm charts
feat: live cm reload
fix: lint and sec bugs
feat: live cm reload
…c/olake-helm into feat/clear_dest
…c/olake-helm into feat/clear_dest
…c/olake-helm into feat/clear_dest
vikaxsh
reviewed
Nov 5, 2025
Comment on lines
+123
to
+124
| workflowID := fmt.Sprintf("sync-%s-%d", req.ProjectID, req.JobID) | ||
| scheduleID := fmt.Sprintf("schedule-%s", workflowID) |
There was a problem hiding this comment.
insted of constructing can we get this from ctx or as function param
There was a problem hiding this comment.
workflowID from context -> sync-123-37-2025-11-05T18:32:05Z
workflowID that we want -> sync-123-37
even in the param we are passing this sync-123-37-2025-11-05T18:32:05Z since we are creating workdir based on this. So we need to construct it manually only
worker/temporal/worker.go
Outdated
|
|
||
| // Register search attributes | ||
| _, err := t.GetClient().OperatorService().AddSearchAttributes(context.Background(), &operatorservice.AddSearchAttributesRequest{ | ||
| SearchAttributes: map[string]enums.IndexedValueType{"OperationType": enums.INDEXED_VALUE_TYPE_KEYWORD}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Temporal workflow and activity logic for executing the Clear Destination process.
Type of change
How Has This Been Tested?