feat: activity pod healthcheck #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: staging to master (helm chart version v0.0.1)
fix: add write permissions for gh token (#11)
feat: add index copy step (#13)
feat: add release workflows (#17)
fix: set task queue (#20)
- Add nfsServer.external.storageClass and size parameters in values.yaml - Modify shared-storage-pvc.yaml to always create PVC with conditional storage class - Simplify _helpers.tpl sharedStoragePVC function to use consistent naming - Add validation error when storageClass is empty and NFS is disabled - Support RWX storage classes like EFS, Azure Files, GCP Filestore, etc.
- Remove PodAntiAffinity that prevented sync pods from running on same node - Allow multiple sync operations to run concurrently for better resource utilization - Keep JobID-based node affinity for resource mapping - Fix tautological condition in affinity assignment
- Add ConfigMapWatcher using client-go informers for live updates - Integrate watcher into K8sPodManager with graceful shutdown - Update pod scheduling to use live mapping instead of static config - Support debouncing (2s) for rapid ConfigMap changes - Maintain backward compatibility with existing Helm charts
feat: live cm reload
fix: lint and sec bugs
feat: live cm reload
…nto refactor/olake-worker
…olake-helm into refactor/olake-worker
schitizsharma
changed the title
vishalm0509
reviewed
Oct 23, 2025
Comment on lines
+253
to
+272
| // Add liveness probe for long-running sync operations | ||
| if req.Command == types.Sync { | ||
| pod.Spec.Containers[0].LivenessProbe = &corev1.Probe{ | ||
| ProbeHandler: corev1.ProbeHandler{ | ||
| Exec: &corev1.ExecAction{ | ||
| Command: []string{ | ||
| "/bin/sh", | ||
| "-c", | ||
| "echo ok > /mnt/config/.healthcheck", | ||
| }, | ||
| }, | ||
| }, | ||
| InitialDelaySeconds: 10, | ||
| PeriodSeconds: 30, | ||
| TimeoutSeconds: 5, | ||
| FailureThreshold: 3, | ||
| SuccessThreshold: 1, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I have added a constant AysncCommands which has all long running tasks. So can we use that here?
// Add liveness probe for long-running sync operations
if slices.Contains(constants.AsyncCommands, req.Command) {
pod.Spec.Containers[0].LivenessProbe = &corev1.Probe{
...
}There was a problem hiding this comment.
I don't see it in this file: https://github.com/datazip-inc/olake-helm/blob/refactor/olake-worker/worker/constants/constants.go where is it located?
There was a problem hiding this comment.
If it is pending on some other PR, then let's change it later on.
There was a problem hiding this comment.
Need to add when clear-destination PR is merged.
shubham19may
previously approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add liveness probe to sync pods
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):