fix: streams section design #240
Open
+107
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalm0509
reviewed
Nov 5, 2025
|
|
||
| setCheckedStatus(newCheckedStatus) | ||
|
|
||
| // sort the grouped streams baseds |
There was a problem hiding this comment.
Unable to understand the comment added
| // sort the grouped streams baseds | ||
| if ( | ||
| Object.keys(groupedStreams).length > 0 && | ||
| sortedGroupedNamespaces.length === 0 |
There was a problem hiding this comment.
Can you also add a comment on why we are checking for
sortedGroupedNamespaces.length === 0There was a problem hiding this comment.
to prevent sorting again when user changes streams. will add a comment for same
There was a problem hiding this comment.
Cool. Will be helpful for contributors
| </div> | ||
|
|
||
| <div className="flex"> | ||
| <div className={`flex rounded-[4px] ${!loading ? "border" : ""}`}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the stream section design issues making it more intuitive and user friendly. Changes include:
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):