feat: add source naming convention#394
Open
deepanshupal09-datazip wants to merge 2 commits into
Open
Conversation
vishalm0509
reviewed
Jun 17, 2026
Comment on lines
+80
to
+81
| // TODO: update this version before final merge | ||
| export const MIN_SOURCE_NAMING_CONVENTION_VERSION = "v0.7.7" |
Collaborator
There was a problem hiding this comment.
Let's not forget to do this before merge
| return selectedStream.selected_columns!.columns.includes(columnName) | ||
| } | ||
|
|
||
| // Returns true if the source version supports the source naming convention feature. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Returns true if the source version supports the source naming convention feature. | |
| // Returns true if the source version supports the `use_source_column_names` feature. |
?
| } | ||
|
|
||
| // Returns true if the source version supports the source naming convention feature. | ||
| export function supportsSourceNamingConvention( |
Collaborator
There was a problem hiding this comment.
Suggested change
| export function supportsSourceNamingConvention( | |
| export function isUseSourceColumnNamesSupported( |
Comment on lines
+45
to
+46
| When enabled, the source naming convention will be applied to | ||
| destination table names. |
Collaborator
There was a problem hiding this comment.
Is this correct description?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Source Naming Convention feature to UI. It will only be visible after v0.7.7 in both bulk edit and single edit.
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):