fix: grpc port binding #576
Open
+172
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…state\n\n- Replace retry/backoff with cooldown logic in FindAvailablePort using portStatus map\n- Kill any process on selected port via lsof/kill without dial checks\n- Mark ports for cooldown on shutdown and on startup/connect failures\n- Keep logger readiness/timeout changes intact\n- Set default cooldown to 300s fix(iceberg): reduce port cooldown to 180 seconds fix: fixed alpine port finding logic and lsof for other linux chore: fixed Postgres readme fix: system imphemeral port conflict retry added
shubham19may
force-pushed
the
fix/grpc-port-binding-3
branch
from
d38385a to
da412d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One java process was finishing with grpc port and other was quickly trying to pick that. But OS takes couple of mins in worst case to release it fully. Also Alpine lsof doesn't work (Need to use ss to find pid which was using that port)
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Documentation
Related PR's (If Any):
Note
Overhauls Iceberg writer port management with cooldown and ss-based PID detection; adds iproute2 to the image; updates Postgres CDC note.
portStatuswith cooldown to avoid reusing recently released ports; marks ports on close.FindAvailablePorttoFindAvailablePort(startPort); addsfindProcessUsingPortpreferringss(fallback tolsof).ss/lsofto find/kill conflicting PIDs; improved error handling and logging.utils/backoffusage and deletesutils/backoff/backoff.go.iproute2forssalongside Java 17.pgoutput(markswal2jsondeprecated).Written by Cursor Bugbot for commit da412d5. This will update automatically on new commits. Configure here.