fix: duplicate table creation by threads #587
Open
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-datazip
commented
Oct 13, 2025
| // if table was already created, this will avoid the error of already exists | ||
| try { | ||
| ((SupportsNamespaces) icebergCatalog).createNamespace(tableIdentifier.namespace()); | ||
| LOGGER.warn("Created namespace:'{}'", tableIdentifier.namespace()); |
There was a problem hiding this comment.
shouldn't this be Info instead of warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier when multiple tables with same destination were being triggered. Each thread tried to create a table , sometimes this table already existed, due to which error was being thrown.
Now the try catch block will handle the already exists exception.
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Documentation
Related PR's (If Any):