constants: centralize GLOBAL state support list and use helper in catalog delta (Fixes #601) #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for checking if a connector type supports GLOBAL state. Signed-off-by: Anudhyan Datta <[email protected]>
Refactor globalStateSupportedConnector check to use constants. Signed-off-by: Anudhyan Datta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #610 with the same two commits, but rebased onto staging as per contribution guidelines.\n\nSummary:\n- Centralize GLOBAL state support list in constants\n- Add constants.IsGlobalStateSupported(connectorType string)\n- Use helper in catalog delta instead of hard-coded checks\n\nSource branch: Anudhyan:fix/pr-610-from-staging\nBase: staging\n\nOnce this is merged, #610 can be closed.