fix: olake sync panics with empty state file#983
Open
Rajat-Bansal3 wants to merge 3 commits into
Open
Conversation
Author
|
I am actually pretty new to open source workflows, so I accidentally made this branch on top of my previous logging branch. Because of that, this PR shows the logging commits as well along with the empty state fix for #244. But don't worry, the changes are independent so it won't cause any git conflicts if you merge them in any order. Let me know if this works or if you want me to clean up and open a fresh one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
unmarshling cleanup using trim and early return
Type of change
How Has This Been Tested?
Screenshots or Recordings
Screencast.from.09-06-26.10.34.47.PM.IST.webm
Documentation
Related PR's (If Any):
NA
#244