Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

Fix multiple problems when using this module in Deno - #5

Open
ahmadov wants to merge 1 commit into
date-fns:mainfrom
ahmadov:fix-multiple-issues
Open

Fix multiple problems when using this module in Deno#5
ahmadov wants to merge 1 commit into
date-fns:mainfrom
ahmadov:fix-multiple-issues

Conversation

@ahmadov

@ahmadov ahmadov commented Jan 26, 2022

Copy link
Copy Markdown
  • Import missing Interval and Duration from types.ts.
  • Fix incorrect paths to submodules.
  • Fix duplicate file ending in import statement.
  • Fix typing of local variable in min function.
  • Fix typo in LocaleOptions in import statement in setDate/index.ts.

* Import missing `Interval` and `Duration` from `types.ts`.
* Fix incorrect paths to submodules.
* Fix duplicate file ending in import statement.
* Fix typing of local variable in `min` function.
* Fix typo in `LocaleOptions` in import statement in `setDate/index.ts`.
@fturmel

fturmel commented Jan 26, 2022

Copy link
Copy Markdown
Member

@ahmadov have a look at the PR date-fns/date-fns#2545. The fixes need to come from the main repo, and have been ready to merge for a long time.

It also seems like the maintainers are uncertain about wanting to keep the Deno version going. The last version published here was 2.23.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants