Skip to content

performance: fix tzOffset cache not working for UTC offset strings #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hotcalpico wants to merge 1 commit into
base: main
Choose a base branch
from
Open

performance: fix tzOffset cache not working for UTC offset strings #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/tzOffset/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ const offsetCache: Record<string, number> = {};
* @returns UTC offset in minutes
*/
export function tzOffset(timeZone: string | undefined, date: Date): number {
if (timeZone! in offsetCache) return offsetCache[timeZone!]!;

try {
const format = (offsetFormatCache[timeZone!] ||= new Intl.DateTimeFormat(
"en-GB",
Expand All @@ -29,7 +31,6 @@ export function tzOffset(timeZone: string | undefined, date: Date): number {
} catch {
// Fallback to manual parsing if the runtime doesn't support 卤HH:MM/卤HHMM/卤HH
// See: https://github.com/nodejs/node/issues/53419
if (timeZone! in offsetCache) return offsetCache[timeZone!]!;
const captures = timeZone?.match(offsetRe);
if (captures) return calcOffset(timeZone!, captures.slice(1));

Expand Down