Fix purple flash when switching private tabs and hide the info block globally - #241
Open
Evoden1 wants to merge 2 commits into
Open
Fix purple flash when switching private tabs and hide the info block globally#241Evoden1 wants to merge 2 commits into
Evoden1 wants to merge 2 commits into
Conversation
Updated CSS to prevent purple background flash in private browsing mode.
…urple rectangle) i removed the felt-privacy media query so the info-border actually displays none for everyone, even if they don't have that setting turned on.
Owner
|
I dont see the purple flash with browser.privatebrowsing.felt-privacy-v1 disabled. |
Author
|
That is because I am using Firefox Nightly (153.0a1), and you are probably testing on the Stable or Beta version. In Nightly, the new private browsing layout is fully rolled out, and the browser.privatebrowsing.felt-privacy-v1 setting has been completely deleted from the browser. Because that preference is gone, the CSS media query fails on my end. This is why the purple flash shows up and the .info-border appears as an empty purple rectangle on my screen. |
Owner
|
Oh yeah I see it in latest Nightly. I will wait for changes to come to stable version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes for the private browsing page were previously wrapped in the
browser.privatebrowsing.felt-privacy-v1media query, meaning they only worked if that experimental setting was turned on inabout:config.I removed this media query from both
userChrome.cssanduserContent.css. Now, the purple flash is resolved when switching private tabs, and the.info-borderblock is successfully hidden for all users.