Repository navigation
feat!: require qsv 27.0.1, and test that minimum in CI - #50
Conversation
qsv 27.0.1 is the first released qsv whose Data Schematics connect to qsv-clientd. Making it the one minimum (MIN_QSV_VERSION, was 25.0.0) removes the code that only ran with an older qsv: the "schematics won't go live" warning in the daemon and the tray, and the private `qsv get` cache for qsv before 27.0.0. An older qsv now raises QsvVersionError; `qsv-clientd serve` exits with it and the tray shows it as an error. Builds that report the withdrawn 27.0.0 are refused too. The new test-min-qsv CI job downloads the release MIN_QSV_VERSION names, checks that qsv, qsvlite and qsvdp report it, and runs the integration tests against each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 99.30% 99.29% -0.01%
==========================================
Files 30 30
Lines 4322 4282 -40
Branches 567 560 -7
==========================================
- Hits 4292 4252 -40
Misses 16 16
Partials 14 14
🚀 New features to boost your workflow:
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -23 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
👀 Worth a closer look
The tray can attach to an already-running daemon without verifying that daemon's qsv version, allowing an unsupported older daemon to remain in use. This should be addressed or explicitly accepted before merging.
One acceptance criterion concerning the CLI service command's exit status and error output appears unverified; the existing tests cover lower-level daemon startup but not the CLI boundary.
About this PR
- Add an integration test for the service CLI entry point that verifies the failure exit status and emitted version error when an unsupported qsv binary is used.
Test suggestions
- Synchronous and asynchronous clients reject qsv 27.0.0 before running a command.
- A binary that does not support --capabilities is rejected as too old.
- min_version raises, but cannot lower, the global 27.0.1 floor.
- The daemon rejects an old binary before creating its socket.
- The tray exposes an old-qsv startup failure as an error state.
- The CLI command qsv-clientd serve exits with status 1 and emits the version error for an old binary.
- The minimum-release CI job downloads and validates qsv, qsvlite, and qsvdp, then runs their integration tests.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. The CLI command qsv-clientd serve exits with status 1 and emits the version error for an old binary.
TIP How was this review? Give us feedback
| - **Behavior change:** qsv 27.0.1 or later is now required (`MIN_QSV_VERSION`, was 25.0.0). | ||
| An older qsv raises `QsvVersionError` before the first command, as a qsv older than 25.0.0 | ||
| did before. `qsv-clientd serve` exits with that error instead of starting with a warning | ||
| that schematics can't connect, and the tray shows it as an error instead of a |
There was a problem hiding this comment.
🟡 MEDIUM RISK
When attaching to an already-running daemon, the tray does not verify the daemon's qsv version. An older daemon can therefore continue using an unsupported qsv without the tray reporting an error. Check the daemon's version during attachment and surface unsupported versions explicitly.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.
Summary
MIN_QSV_VERSION, was 25.0.0). It is the first released qsv whose Data Schematics connect toqsv-clientd, so there's no longer a separate, lower minimum for the rest of the library.QsvVersionErrorbefore the first command.qsv-clientd serveexits 1 withqsv-clientd: … is qsv 26.0.0; at least 27.0.1 is requiredinstead of starting with a warning, and the tray shows the same message as an error.schematics_noticeand theLIVE_SCHEMATICS_*constants, with the daemon's startup warning and the tray's_note_qsv.qsv getcache (_get_cache_env) for qsv before 27.0.0.test-min-qsvjob downloads the releaseMIN_QSV_VERSIONnames (so it can't drift), fails unlessqsv,qsvliteandqsvdpeach report that version, and runs the integration tests against all three. The other jobs keep testing the latest release, which is now 29.0.0.Testing
test_integration.pyandtest_integration_daemon.pypass against qsv 27.0.1, andtest_integration.pyagainst qsvlite 27.0.1 (macOS aarch64).qsv-clientd serveagainst a fake qsv 26.0.0 prints the version error and exits 1.mypy --platform win32and actionlint are clean.🤖 Generated with Claude Code