Skip to content

feat!: require qsv 27.0.1, and test that minimum in CI - #50

Merged
jqnatividad merged 1 commit into
mainfrom
feat/min-qsv-27.0.1
Nov 16, 2026
Merged

jqnatividad merged 1 commit into
mainfrom
feat/min-qsv-27.0.1

Conversation

@jqnatividad

Copy link
Copy Markdown
Contributor

Summary

  • Behavior change: qsv 27.0.1 or later is now required for everything (MIN_QSV_VERSION, was 25.0.0). It is the first released qsv whose Data Schematics connect to qsv-clientd, so there's no longer a separate, lower minimum for the rest of the library.
    • An older qsv raises QsvVersionError before the first command.
    • qsv-clientd serve exits 1 with qsv-clientd: … is qsv 26.0.0; at least 27.0.1 is required instead of starting with a warning, and the tray shows the same message as an error.
    • Development builds that report the withdrawn 27.0.0 are refused too. Any qsv built since reports a later version.
  • Removed code that no qsv we accept can reach:
    • schematics_notice and the LIVE_SCHEMATICS_* constants, with the daemon's startup warning and the tray's _note_qsv.
    • The private qsv get cache (_get_cache_env) for qsv before 27.0.0.
  • CI: the new test-min-qsv job downloads the release MIN_QSV_VERSION names (so it can't drift), fails unless qsv, qsvlite and qsvdp each report that version, and runs the integration tests against all three. The other jobs keep testing the latest release, which is now 29.0.0.

Testing

  • The full suite passes against qsv 29.0.0: 800 passed, 2 skipped.
  • test_integration.py and test_integration_daemon.py pass against qsv 27.0.1, and test_integration.py against qsvlite 27.0.1 (macOS aarch64).
  • qsv-clientd serve against a fake qsv 26.0.0 prints the version error and exits 1.
  • ruff, mypy, mypy --platform win32 and actionlint are clean.
  • The qsvdp part of the new job runs for the first time on this PR, since qsvdp only ships for Linux.

🤖 Generated with Claude Code

qsv 27.0.1 is the first released qsv whose Data Schematics connect to
qsv-clientd. Making it the one minimum (MIN_QSV_VERSION, was 25.0.0)
removes the code that only ran with an older qsv: the "schematics won't
go live" warning in the daemon and the tray, and the private `qsv get`
cache for qsv before 27.0.0. An older qsv now raises QsvVersionError;
`qsv-clientd serve` exits with it and the tray shows it as an error.
Builds that report the withdrawn 27.0.0 are refused too.

The new test-min-qsv CI job downloads the release MIN_QSV_VERSION names,
checks that qsv, qsvlite and qsvdp report it, and runs the integration
tests against each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.29%. Comparing base (dd2d6ae) to head (06caed5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   99.30%   99.29%   -0.01%     
==========================================
  Files          30       30              
  Lines        4322     4282      -40     
  Branches      567      560       -7     
==========================================
- Hits         4292     4252      -40     
  Misses         16       16              
  Partials       14       14              
Files with missing lines Coverage Δ
src/qsv_client/__init__.py 100.00% <ø> (ø)
src/qsv_client/client.py 100.00% <100.00%> (ø)
src/qsv_client/daemon/config.py 100.00% <ø> (ø)
src/qsv_client/daemon/fetch.py 100.00% <100.00%> (ø)
src/qsv_client/daemon/server.py 98.94% <ø> (-0.01%) ⬇️
src/qsv_client/errors.py 100.00% <ø> (ø)
src/qsv_client/tray/controller.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -23 complexity · 0 duplication

Metric Results
Complexity -23
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

👀 Worth a closer look

The tray can attach to an already-running daemon without verifying that daemon's qsv version, allowing an unsupported older daemon to remain in use. This should be addressed or explicitly accepted before merging.

One acceptance criterion concerning the CLI service command's exit status and error output appears unverified; the existing tests cover lower-level daemon startup but not the CLI boundary.

About this PR

  • Add an integration test for the service CLI entry point that verifies the failure exit status and emitted version error when an unsupported qsv binary is used.

Test suggestions

  • Synchronous and asynchronous clients reject qsv 27.0.0 before running a command.
  • A binary that does not support --capabilities is rejected as too old.
  • min_version raises, but cannot lower, the global 27.0.1 floor.
  • The daemon rejects an old binary before creating its socket.
  • The tray exposes an old-qsv startup failure as an error state.
  • The CLI command qsv-clientd serve exits with status 1 and emits the version error for an old binary.
  • The minimum-release CI job downloads and validates qsv, qsvlite, and qsvdp, then runs their integration tests.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. The CLI command qsv-clientd serve exits with status 1 and emits the version error for an old binary.

TIP How was this review? Give us feedback

Comment thread CHANGELOG.md
- **Behavior change:** qsv 27.0.1 or later is now required (`MIN_QSV_VERSION`, was 25.0.0).
An older qsv raises `QsvVersionError` before the first command, as a qsv older than 25.0.0
did before. `qsv-clientd serve` exits with that error instead of starting with a warning
that schematics can't connect, and the tray shows it as an error instead of a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

When attaching to an already-running daemon, the tray does not verify the daemon's qsv version. An older daemon can therefore continue using an unsupported qsv without the tray reporting an error. Check the daemon's version during attachment and surface unsupported versions explicitly.

TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.

@jqnatividad
jqnatividad merged commit 8e66ff0 into main Nov 16, 2026
23 checks passed
@jqnatividad
jqnatividad deleted the feat/min-qsv-27.0.1 branch November 16, 2026 03:43
@jqnatividad jqnatividad mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant