Skip to content

WIP: Improve whole logic for approval workflow #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sagargg wants to merge 37 commits into
base: master
Choose a base branch
from
Open

WIP: Improve whole logic for approval workflow #8

sagargg wants to merge 37 commits into from

Conversation

@sagargg
Copy link
Member

@sagargg sagargg commented Apr 8, 2024 •
edited
Loading

  • Avoided complex logic on approval flow.
  • Removed extra metadata publish status and use the core state for storing publishing status.
  • Users cannot edit dataset that are already submitted for review.
  • Avoided complex templates overriding making minimal changes.
  • Added unit tests.

Note: This only works for CKAN > v2.10.x

gavram and others added 24 commits February 13, 2024 08:15
@gavram
CKAN 2.10.x compatibility fixes
830873e
@gavram
Sigma2 initial commit
6f4b052
@gavram
Remove template file
0bf87ef
@gavram
Creation process functionality
c577903
@gavram
Latest fixes
345d5b1
@gavram
Previous button fix
6a9eec6
@gavram
Block direct access to /dataset/new route
f14d38a
@gavram
Remove unnecessary code
ad910cb
@gavram
Add custom metadata schema
674fcfe
@gavram
Handling stages initial commit
ecc6e6c
@gavram
Ignore vs code settings
8ae142e
@gavram
keep the changes in safe place
9f71193
@mohamedsalem401
fix dataset creation steps styles
4537560
@gavram
Merge branch 'sigma2' of https://github.com/datopian/ckanext-dataseta…
300ae5e 
…pproval into sigma2
@gavram
Latest improvements with temporary metadata schema
92711da
@gavram
Butons bugs and improved functionallity
3a66269
@gavram
Fixing Save Draft button on dataset new page
69413a7
@gavram
Additional fixes in template file
e80f8e5
@gavram
Improved dataset schema but not finished yet
3e9b4b4
@gavram
Fixing Add and add another button functionallity
d954635
@gavram
Fixing stages and buttons on resource edit page
536230c
@gavram
Licenses field added
8fa1cce
@gavram
Latest dataset schema, not finished yet
8906ee9
@sagargg
[Refractor][xl]: Refractored code, work with buit in state metadata a…
4f5e8bc 
…nd avoid complex logic etc
@sagargg sagargg changed the title Improve whole logic for approval workflow WIP: Improve whole logic for approval workflow Apr 10, 2024
@ivanrvpereira
Copy link

ivanrvpereira commented Sep 15, 2025

Any chance of this being merged soon?

@sagargg
Copy link
Member Author

sagargg commented Sep 15, 2025

@gavram Do you think we can merge this ?

@valentinmirchev
Copy link

valentinmirchev commented Oct 6, 2025

@sagargg @gavram do you have any updates on this PR? Should we expect a merge in the following days? Weeks? Months?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sagargg @ivanrvpereira @valentinmirchev @gavram @mohamedsalem401