fix(dns-records): restore BIND file import broken by dropdown blur-close#1329
Merged
Merged
Conversation
@radix-ui/react-menu >=2.1.17 (pulled in by the June dependency update) closes any open menu on window blur. The import dropzone lives inside ResponsiveDropdown, so opening the native file picker — or switching apps to drag a zone file in — blurred the window, closed the dropdown, and unmounted the dropzone before onDrop ever fired: no dialog, no error, no processing. - Bump @datum-cloud/datum-ui to ^1.3.2, whose ResponsiveDropdown renders a Radix Popover on desktop (same UX, no blur-close) — see datum-cloud/datum-ui#136 - handleDrop now reports whether the preview dialog opened; the dropdown only closes on success so parse errors stay visible in the dropzone - Empty accepted-file drops surface an error instead of returning silently
🧪 Test Summary
📎 ArtifactsVideos and screenshots from failed E2E tests: |
yahyafakhroji
changed the title
🧪 Test Summary
📎 ArtifactsVideos and screenshots from failed E2E tests: |
yahyafakhroji
force-pushed
the
fix/dns-record-import-dropdown-blur
branch
from
d1abc7d to
962e475
Compare
yahyafakhroji
changed the title
🧪 Test Summary
📎 ArtifactsVideos and screenshots from failed E2E tests: |
yahyafakhroji
force-pushed
the
fix/dns-record-import-dropdown-blur
branch
from
1b1692a to
962e475
Compare
🧪 Test Summary
📎 ArtifactsVideos and screenshots from failed E2E tests: |
mattdjenkinson
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Importing a BIND zone file on the DNS records page did nothing — no preview dialog, no error, no processing.
Root cause:
@radix-ui/react-menu≥2.1.17 (pulled in by #1321) closes any open menu on window blur. The import dropzone lives insideResponsiveDropdown(a Radix DropdownMenu on desktop), so clicking Select a file (native picker) or dragging a file in from Finder blurred the window, closed the dropdown, and unmounted the dropzone beforeonDropfired.Fix
@datum-cloud/datum-uito ^1.3.2 —ResponsiveDropdownrenders a Radix Popover on desktop (same UX, no blur-close). Upstream: fix(responsive-dropdown): keep dropdown open when window loses focus datum-ui#136.handleDropreports whether the preview opened; the dropdown only closes on success so parse errors stay visible.Test plan
Note
The E2E regression checks are red due to a separate, pre-existing control-plane change (org creation now requires a system-assigned
generateName;createStandardOrgfails with 422). It's unrelated to this PR and affectsmaintoo — tracked/fixed separately.