feat(quota): add display names and descriptions to compute quota limits#151
Merged
Merged
Conversation
Populate displayName/description on each spec.quota.limits[] entry so the service-catalog quota fan-out stamps kubernetes.io/display-name and kubernetes.io/description on the generated ResourceRegistrations. Portals (cloud-portal Quotas) then render readable names (Instances, vCPUs, Memory, Workloads) instead of raw compute.datumapis.com/* metric keys. Requires the QuotaLimitSpec display fields from milo-os/service-catalog#41.
savme
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Populate
displayName+descriptionon eachspec.quota.limits[]entry in the computeServiceConfiguration:Why
The service-catalog quota fan-out generates a
ResourceRegistrationper limit. With these fields populated it stampskubernetes.io/display-name/kubernetes.io/description, so portals (cloud-portal Quotas) render readable names instead of rawcompute.datumapis.com/*metric keys.milo-os/service-catalog#41 — adds
DisplayName/DescriptiontoQuotaLimitSpec. This PR is draft until that lands and theServiceConfigurationCRD with the new schema is deployed; applying before then would be rejected as unknown fields.Related