Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331
Open
kevwilliams wants to merge 7 commits intomainfrom
Open
Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331kevwilliams wants to merge 7 commits intomainfrom
kevwilliams wants to merge 7 commits intomainfrom
Conversation
Contributor
|
Hey guys, are you seeing the same error when trying to run this, or is it just not ready to be reviewed yet? |
|
@gaghan430 yes, i experienced the same thing |
Author
|
I did not see this but I will check my working copy and see if there's something I am missing in the Pr thanks for checking! |
Author
|
@yahyafakhroji @gaghan430 This should be ready for another look! Thank you! |
Contributor
|
nice... but I think some styles are broken your branch vs staging Screen.Recording.2026-02-20.at.09.37.44.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing all uses of @datum-ui/button with the design system, importing @datum-cloud/datum-ui button.