Add config options AlwaysIncludeTrailingComma, DisableNilValues#60
Open
atombender wants to merge 2 commits intodavecgh:masterfrom
Open
Add config options AlwaysIncludeTrailingComma, DisableNilValues#60atombender wants to merge 2 commits intodavecgh:masterfrom
atombender wants to merge 2 commits intodavecgh:masterfrom
Conversation
…g of commas in arrays/slices/maps. Useful in tests to avoid false positives when diffing.
…o include nil fields. This is useful in tests that rely on "golden" test data: Often one adds a new, optional field to a struct, and it's onerous to update all test data to reflect this field, which would now be nil everywhere.
Contributor
Author
|
Oh, and this fixes #54. |
Contributor
Author
|
@davecgh Thoughts? I was thinking of changing the nil functionality to disable all zero values, which will cover more use cases. |
Closed
|
I really like the |
|
@davecgh do you think we could move this along? It would help us resolve stretchr/testify#288. Or, if it's not going to happen, we can just close that or maybe try to fix it on our end. Either way works for me. |
|
For the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds config option
AlwaysIncludeTrailingComma, which forces the writing of commas in arrays/slices/maps. Useful in tests to avoid false positives when diffing. This is a prerequisite to resolving this Testify issue.Building on that commit is a new config option
DisableNilValues. Background: We have a bunch of tests that use Spew to generate "golden" test data. This is great, but often one adds a new, optional field to a struct that's part of this data, and suddenly all the test data is broken because the new filed isnileverywhere. It's onerous to update all test data for such zero-value fields. This fixes that.