fixing compilation problems #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listed below
-because lack of '\0' in header, changing strncpy to memcpy
-changing size of format buffer to fit the format string
-suggestion to use memset rather tha for loop to fill buffer with space ' '
-very nasty workaround to -Werror=address-of-packed-member for struct hashpipe_ibv_flow wattr
add ignore pragma to ignore warnings for troublesome line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listed below
-because lack of '\0' in header, changing strncpy to memcpy
-changing size of format buffer to fit the format string
-suggestion to use memset rather tha for loop to fill buffer with space ' '
-very nasty workaround to -Werror=address-of-packed-member for struct hashpipe_ibv_flow attr. I don't like that approach. Maybe just forcing to ignore address-of-packed-member is better, as attr is the first attribute and it will be aligned