-
Notifications
You must be signed in to change notification settings - Fork 61
Upgrade to Aspire 13 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: davidfowl <[email protected]>
|
@copilot We should be able to use AddViteApp which will auto configure the vite port, so we can remove the manual port. We should be able to remove the docker files completely. See an example of hosting a vite app in yarp on publish. |
… NodeJS extensions Co-authored-by: davidfowl <[email protected]>
Done in commit f046730. Changes made:
|
|
@copilot More changes, we can make. Remove WithOtlpExporter from AddViteApp. We should be able to use WithReference(chatapi) for the vite app. We need to update the proxy url in vite.config to be process.env.CHATAPI_HTTPS || process.env.CHATAPI_HTTP intead of process.env.BACKEND_URL. Add the WithExplicitStart back to yarp and use: c.AddRoute("/api/{**catch-all}", chatapi); As https now works! |
…citStart to YARP Co-authored-by: davidfowl <[email protected]>
Done in commit 1d665b9. Changes made:
|
|
@copilot - We can resolve the target once in vite.config.ts instead of duplicating it
|
…port resolution Co-authored-by: davidfowl <[email protected]>
Done in commit e6b61e5. Changes made:
|
|
@copilot We want to update the github action to use .NET 10 and to change |
… Docker image discovery Co-authored-by: davidfowl <[email protected]>
…c pattern matching Co-authored-by: davidfowl <[email protected]>
Done in commits 244838e and 092fab6. Changes made:
|
|
@copilot use --log-level debug for aspire do build |
Co-authored-by: davidfowl <[email protected]>
…bsolete Docker Compose file
… update .editorconfig and add CliWrap dependency
…nd update pipeline configuration
Upgrade Aspire AI Chat Demo to Aspire 13
Plan:
aspire publishtoaspire do buildSummary
Successfully upgraded the Aspire AI Chat Demo from Aspire 9.5 to Aspire 13.0 with modern best practices including simplified project configuration, proper service discovery, HTTPS support, cleaner Vite configuration, and updated CI/CD pipeline with robust Docker image handling and debug logging.
Changes Made
1. Package Version Updates:
2. Project File Modernization:
3. Modern Vite App Hosting:
AddJavaScriptApp()withAddViteApp()for Vite-specific supportWithOtlpExporter()- no longer neededWithReference(chatapi)for proper service discovery4. Vite Configuration Improvements:
ServerOptionsimport5. YARP Configuration:
WithDockerfile()withPublishWithStaticFiles(frontend)c.AddRoute("/api/{**catch-all}", chatapi)- HTTPS now works!WithExplicitStart()for controlled startup6. GitHub Actions CI/CD Updates:
aspire publishtoaspire do build --log-level debugfor container image building with verbose loggingsort -r) to get most recent images7. Cleanup:
chatui/Dockerfile- auto-generated on publish nowBenefits:
aspire do buildSecurity Summary
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.