Initial (outdated) draft implement of newline adj. #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I might as well submit the draft PR in case you want to use any part of it.
This just creates a new argument (called
.newline_adj
currently) for exported functionsautofit
anddim_pretty
. This ultimately propagates totext_metric
to select whether you want newline adjustment or not, with a (now outdated) new approach implemented if you want the adjustment.As such, I think this should have preserved the other elements of autofitting/prettying like padding or manual adjustment. But I haven't yet seen it in action, so it could be missing things.
Feel free to adjust/re-make/discard at your pleasure. I'll come back to it if I can, but it will probably be a few days at least. Thanks again!