Skip to content

Initial (outdated) draft implement of newline adj. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jmobrien
Copy link

Thought I might as well submit the draft PR in case you want to use any part of it.

This just creates a new argument (called .newline_adj currently) for exported functions autofit and dim_pretty. This ultimately propagates to text_metric to select whether you want newline adjustment or not, with a (now outdated) new approach implemented if you want the adjustment.

As such, I think this should have preserved the other elements of autofitting/prettying like padding or manual adjustment. But I haven't yet seen it in action, so it could be missing things.

Feel free to adjust/re-make/discard at your pleasure. I'll come back to it if I can, but it will probably be a few days at least. Thanks again!

@davidgohel
Copy link
Owner

many thanks @jmobrien I'll give a try to see how it can be integrated (and let you know when I will)

@davidgohel davidgohel closed this Jun 14, 2022
@jmobrien jmobrien deleted the autofit_newline branch June 14, 2022 23:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants