Skip to content

adds theme_apa #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2022
Merged

adds theme_apa #445

merged 4 commits into from
Sep 7, 2022

Conversation

rempsyc
Copy link
Contributor

@rempsyc rempsyc commented Aug 25, 2022

Experimental attempt no 1, ready for future iterations. Not sure if discussion should continue here or in #426.

@davidgohel
Copy link
Owner

Could you to add an entry in NEWS.md and add your name as 'ctb' in DESCRIPTION?

@davidgohel
Copy link
Owner

davidgohel commented Sep 7, 2022

sorry, can you remove the authors part in pkgdown.yaml ?

@rempsyc
Copy link
Contributor Author

rempsyc commented Sep 7, 2022

Sorry about that. I have removed it. I initially thought it might be nice to have the author's (you) and other contributors' sites on this page: https://davidgohel.github.io/flextable/authors.html

Like, e.g., for performance package: https://easystats.github.io/performance/authors.html

@davidgohel
Copy link
Owner

Thanks!

PS: I will look at this author page. I never really spend time on it to be frank. Once I will populate the page your name will be part of this list

@davidgohel davidgohel merged commit 46b456e into davidgohel:master Sep 7, 2022
@rempsyc
Copy link
Contributor Author

rempsyc commented Sep 7, 2022

Just to clarify, the author page is created automatically from the DESCRIPTION file by pkgdown. Adding authors to _pkgyml is not actually adding "authors" to the package, it just adds links to personal websites for contributors, but only if people are listed in the DESCRIPTION file already (else it is ignored), i.e., it doesn't add people as authors or contributors by itself.

The reason it is named the "authors" section in _pkgyml and in the pkgdown site is because this is what the DESCRIPTION file uses.

@davidgohel
Copy link
Owner

davidgohel commented Sep 7, 2022

OK! dummy me! I'll add back your link in the yaml file

@davidgohel
Copy link
Owner

done

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants