Skip to content

grob support #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2022
Merged

grob support #446

merged 6 commits into from
Sep 3, 2022

Conversation

sigmapi
Copy link
Collaborator

@sigmapi sigmapi commented Aug 26, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #446 (c63085d) into master (fe59ce1) will decrease coverage by 9.13%.
The diff coverage is 2.05%.

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   58.51%   49.37%   -9.14%     
==========================================
  Files          43       46       +3     
  Lines        5761     7155    +1394     
==========================================
+ Hits         3371     3533     +162     
- Misses       2390     3622    +1232     
Impacted Files Coverage Δ
R/flextable_sizes.R 84.77% <ø> (-0.08%) ⬇️
R/grid_funs.R 0.00% <0.00%> (ø)
R/grid_grobs.R 0.00% <0.00%> (ø)
R/printers.R 50.97% <0.00%> (+1.16%) ⬆️
R/read_structure.R 98.13% <100.00%> (-0.02%) ⬇️
R/00_utils.R 86.48% <0.00%> (-8.68%) ⬇️
R/latex_chunks.R 75.00% <0.00%> (-5.91%) ⬇️
R/05_content.R 54.00% <0.00%> (-5.56%) ⬇️
R/html_str.R 80.88% <0.00%> (-5.02%) ⬇️
R/flextable.R 75.00% <0.00%> (-3.58%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davidgohel
Copy link
Owner

hello @sigmapi

Thanks a lot again. I tested it with a lot of existing examples, and it works very well.

Let's merge

@davidgohel davidgohel merged commit b87b95f into master Sep 3, 2022
@sigmapi
Copy link
Collaborator Author

sigmapi commented Sep 3, 2022

Great, thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
@davidgohel davidgohel deleted the dev_grob branch September 4, 2023 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants