Skip to content

Prevent Rcpp from masking valid uses of Rf_error #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgohel merged 1 commit into from
Jan 16, 2026
Merged

Prevent Rcpp from masking valid uses of Rf_error #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Makevars
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
PKG_CPPFLAGS = -DRCPP_NO_MASK_RF_ERROR
PKG_LIBS = -lpng -lz
3 changes: 2 additions & 1 deletion src/Makevars.ucrt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ else
PKG_LIBS = $(shell pkg-config --libs libpng)
endif

PKG_CPPFLAGS += -DSTRICT_R_HEADERS
PKG_CPPFLAGS += -DSTRICT_R_HEADERS \
-DRCPP_NO_MASK_RF_ERROR
3 changes: 2 additions & 1 deletion src/Makevars.win
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
RWINLIB = ../windows/harfbuzz-2.7.4

PKG_CPPFLAGS = -I${RWINLIB}/include \
-DSTRICT_R_HEADERS
-DSTRICT_R_HEADERS \
-DRCPP_NO_MASK_RF_ERROR

PKG_LIBS = -L${RWINLIB}/lib${R_ARCH}${CRT} -lpng -lz

Expand Down