Skip to content

Conversation

Copy link

Copilot AI commented Dec 22, 2025

Pull request type:

  • Feature
  • Bug fix
  • Documentation
  • Breaking change

I have:

  • Tested the code
  • Wrote unit tests for the code
  • Documented changes:
    • Guide(s)
    • API reference
    • Changelog

Changes:

  • Removed asyncmy dependency (unmaintained, no longer pre-built)
  • Removed MySQL/MariaDB dialect support from LoggerSQL
  • Updated supported dialects: SQLite, Microsoft SQL Server, PostgreSQL
  • Added v5.0.0 changelog entry marking this as breaking change

Modified files:

  • requirements/sql.txt: Removed asyncmy package
  • src/daf/logging/sql/mgr.py: Removed MySQL from DIALECT_CONN_MAP and type hints
  • docs/source/guide/core/logging.rst: Updated dialect list and feature documentation
  • docs/source/changelog.rst: Added v5.0.0 breaking change entry

Note: Thesis documentation (docs/thesis/) remains unchanged as it is a finished historical document.

Migration:
Users with MySQL databases need to migrate to PostgreSQL, SQLite, or MSSQL before upgrading to v5.0.0.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Enhancement:] Remove asyncmy dependency</issue_title>
<issue_description>### Summary

Remove the asyncmy as it is no longer maintained and pre-built.

Basic Example

/

Unresolved questions

No response</issue_description>

<agent_instructions>Remove the dependency in question and also update the code to not consider it. Add an entry to the documentation under version 5.0.0 in the changelog.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove asyncmy dependency from project Remove asyncmy dependency and MySQL support Dec 22, 2025
Copilot AI requested a review from davidhozic December 22, 2025 01:41
@davidhozic
Copy link
Owner

Don't change anything in docs/thesis. That is already finished.

@copilot

Copy link
Author

Copilot AI commented Dec 22, 2025

Don't change anything in docs/thesis. That is already finished.

@copilot

Reverted the thesis documentation changes in commit a51a4b0. The docs/thesis files are now back to their original state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement:] Remove asyncmy dependency

2 participants