Skip to content

Support quoted actions#27

Open
jaimergp wants to merge 3 commits into
davidism:mainfrom
jaimergp:patch-1
Open

Support quoted actions#27
jaimergp wants to merge 3 commits into
davidism:mainfrom
jaimergp:patch-1

Conversation

@jaimergp

Copy link
Copy Markdown

Noticed gha-update chokes on this type of input (note quoted uses value):

      - id: 'auth'
        name: 'Authenticate to Google Cloud'
        uses: 'google-github-actions/auth@v0'
        with:
          credentials_json: ${{ secrets.GOOGLE_CREDENTIALS }}

Comment thread src/gha_update/_core.py Outdated
@davidism

Copy link
Copy Markdown
Owner

Nice! I intended to fix this with a broader refactor, but I ran out of time. Thanks.

@jaimergp

Copy link
Copy Markdown
Author

@davidism sorry I forgot about this, I now applied your suggestion. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants