Draft
Fix role permissions error in the sync scheduled task#116
Conversation
Co-authored-by: davidjrh <489976+davidjrh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Role permissions error in the sync scheduled task
Fix role permissions error in the sync scheduled task
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When a role is deleted on EntraID, during the next sync cycle the DNN Local role associated with that role will be deleted. If that role has been used to give permissions to a specific workspace or report through the persona bar (storing the permissions in the
PBI_ObjectPermissionstable), the synchronization fails to delete the roles because the foreign key betweenPBI_ObjectPermissionsandRolesis not set as DELETE CASCADE.Solution
Added code to delete entries in the
PBI_ObjectPermissionstable before deleting the role itself. This approach is consistent with the existing workaround forRoleSettingsthat was already in the codebase.The changes:
PBI_ObjectPermissionstable for the role being deletedRoleSettingsintactThis prevents foreign key constraint violations when deleting roles that have been used for permissions in the persona bar.
Fixes #115.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
_https._tcp.esm.ubuntu.com/usr/lib/apt/methods/https(dns block)_https._tcp.motd.ubuntu.com/usr/lib/apt/methods/https(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)motd.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.