Skip to content

Conversation

@jeremy-visionaid
Copy link
Contributor

@jeremy-visionaid jeremy-visionaid commented May 28, 2025

Fixes: #27

@jeremy-visionaid
Copy link
Contributor Author

I can't promise this is perfect as I have an NZ keyboard which has some quirks. But since there's a few intertwined issues, I reckon we should just merge this and fix up any other problems later.

@jeremy-visionaid jeremy-visionaid marked this pull request as ready for review May 28, 2025 23:51
@jeremy-visionaid
Copy link
Contributor Author

jeremy-visionaid commented May 29, 2025

I note that NumPadDecimal seems to duplicate NumPadPeriod (i.e. NumPadDecimal should probably be removed in another commit/PR). GraveAccent also possibly duplicates Backquote

Copy link
Contributor Author

@jeremy-visionaid jeremy-visionaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure I agree with CoPilot's suggestions TBH... It removes the grouping from the NativeMethods. The using change is neither here nor there, but the change breaks the formatting, so another change will be needed to fix it, and maybe creates a bunch of conflicts, so probably better to just put it back as it was IMHO.

The editorconfig generally isn't being respected through the project, which I've tried to be sympathetic too when staging fixes (it makes the IDE think there's a bunch of errors/warnings) which don't apply at build time, but that should probably be fixed up as a separate issue later.

@davidortinau
Copy link
Owner

@jeremy-visionaid I totally agree, the Copilot reviews are not amazing yet. I'm mostly using them to just test it out.

@davidortinau davidortinau merged commit eef95bb into davidortinau:main May 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing key mappings on Windows

2 participants