fix: Sum BMS1 and BMS2 battery power for dual BMS parallel mode | Deye 3P#1061
Open
catrielmuller wants to merge 1 commit into
Open
fix: Sum BMS1 and BMS2 battery power for dual BMS parallel mode | Deye 3P#1061catrielmuller wants to merge 1 commit into
catrielmuller wants to merge 1 commit into
Conversation
…e 3P In bat1 & bat2 parallel mode, register 0x024E (BMS1) only reports half the actual battery power. Register 0x0253 holds BMS2 power and must be summed to get the correct total, matching the existing behavior of Battery Current which already sums 0x024F (BMS1) + 0x0252 (BMS2). Also applies the same fix to the Power Losses calculation which uses battery power as one of its inputs. Verified on a Deye HV 3-Phase Hybrid Inverter with Pylontech BMS: - Battery Voltage: ~430V, Battery Current: ~6.4A -> V*I ~ 2737W (real) - Battery Power reported (before fix): ~1350W (exactly half, BMS1 only) - Load UPS Power: ~2473W -> confirmed real total ~2460W after losses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Deye 3P inverter is configured in bat1 & bat2 parallel mode (dual BMS connected to both battery ports),
Battery Powerreports exactly half the actual battery power.Root cause
Register
0x024Eonly holds the power reported by BMS1. In single-BMS configurations this is correct, but in parallel mode BMS2 contributes an equal share of power that is never accounted for.This is inconsistent with how
Battery Currentis already handled — it correctly sums both BMS ports:But
Battery Powerwas reading only one side:Verification
Tested on a Deye HV 3-Phase Hybrid Inverter with Pylontech BMS in bat1&bat2 parallel mode:
battery_voltagebattery_currentbattery_voltage × battery_currentbattery_power(before fix)load_ups_powerThe ratio
V×I / battery_powerwas consistently 2.000 across 20+ samples, confirming only one BMS was being counted.Fix
Apply the same dual-sensor pattern already used for
Battery Current, summing registers0x024E(BMS1) and0x0253(BMS2):The same fix is applied to the Power Losses calculation, which also uses battery power as an input and was therefore underreporting losses by the same margin.
Related
0x024E/0x0253) as part of a broader BMS2 support addition. This PR is a focused, minimal fix for the battery power regression only.