Skip to content

tests: update golden files and create SCIP snapshot with strict=false #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrjenni merged 1 commit into from
Mar 28, 2026
Merged

tests: update golden files and create SCIP snapshot with strict=false #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Indexer/IndexerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function testIndexer(): void
$actualPath = self::TESTDATA_DIR . 'actual';

$output = [];
$result = exec("scip snapshot --from {$this->indexFile} --to {$actualPath}", $output);
$result = exec("scip snapshot --strict=false --from={$this->indexFile} --to={$actualPath}", $output);
if ($result === false) {
self::fail('Error executing scip: ' . ($output[0] ?? 'no output') . '.');
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Indexer/testdata/golden/src/ClassA.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function __construct(?int $p) { $this->z1 = $p; }
1 => $this->a1,
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassA#$a1.
PHP_MAJOR_VERSION => $this->a1?->b1,
// ^^^^^^^^^^^^^^^^^ reference scip-php composer php 8.4.15 PHP_MAJOR_VERSION.
// ^^^^^^^^^^^^^^^^^ reference scip-php composer php 8.4.19 PHP_MAJOR_VERSION.
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassA#$a1.
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassB#$b1.
})->b2;
Expand Down
4 changes: 2 additions & 2 deletions tests/Indexer/testdata/golden/src/ClassF.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace TestData;

use function strlen;
// ^^^^^^ reference scip-php composer php 8.4.15 strlen().
// ^^^^^^ reference scip-php composer php 8.4.19 strlen().

/** @method ClassA m1(int $p1, $p2, bool $p3) */
// ^^ definition scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassF#m1().
Expand Down Expand Up @@ -50,7 +50,7 @@ public function f1(): int
{
return $this->f1 + 42 + strlen('ABC');
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassF#$f1.
// ^^^^^^ reference scip-php composer php 8.4.15 strlen().
// ^^^^^^ reference scip-php composer php 8.4.19 strlen().
}

public static function f2(): ClassA
Expand Down
10 changes: 5 additions & 5 deletions tests/Indexer/testdata/golden/src/ClassH.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
namespace TestData
{
use Exception;
// ^^^^^^^^^ reference scip-php composer php 8.4.15 Exception#
// ^^^^^^^^^ reference scip-php composer php 8.4.19 Exception#

final class ClassH extends Exception
// ^^^^^^ definition scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassH#
// documentation
// > ```php
// > final class ClassH extends Exception
// > ```
// ^^^^^^^^^ reference scip-php composer php 8.4.15 Exception#
// ^^^^^^^^^ reference scip-php composer php 8.4.19 Exception#
{

public function __construct()
Expand All @@ -24,8 +24,8 @@ public function __construct()
// > ```
{
parent::__construct();
// ^^^^^^ reference scip-php composer php 8.4.15 Exception#
// ^^^^^^^^^^^ reference scip-php composer php 8.4.15 Exception#__construct().
// ^^^^^^ reference scip-php composer php 8.4.19 Exception#
// ^^^^^^^^^^^ reference scip-php composer php 8.4.19 Exception#__construct().
}

public function h1(): int
Expand All @@ -40,7 +40,7 @@ public function h1(): int
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassF#f2().
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassA#a2().
return $this->getCode() + fun2()->a2() * $x;
// ^^^^^^^ reference scip-php composer php 8.4.15 Exception#getCode().
// ^^^^^^^ reference scip-php composer php 8.4.19 Exception#getCode().
// ^^^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 fun2().
// ^^ reference scip-php composer davidrjenni/scip-php-test 2879a47ba00225b1d0cf31ebe8b9fc7f6cd28be5 TestData/ClassA#a2().
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Indexer/testdata/golden/src/TraitE.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function e3(): int
{
if (true) {
return 23 - count([0]);
// ^^^^^ reference scip-php composer php 8.4.15 count().
// ^^^^^ reference scip-php composer php 8.4.19 count().
}
if (false) {
return 42;
Expand Down
Loading