Skip to content

Improve support for Ruby #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

AjaiKN
Copy link
Contributor

@AjaiKN AjaiKN commented Nov 11, 2024

No description provided.

@davidshepherd7
Copy link
Owner

Looks nice!

Could you have a go at adding a test for | and maybe * and **? But if you can't get it to work then we can merge anyway and I'll do it some time later.

@AjaiKN AjaiKN force-pushed the ruby branch 3 times, most recently from 733d56e to 6b66a06 Compare November 11, 2024 23:07
@AjaiKN
Copy link
Contributor Author

AjaiKN commented Nov 11, 2024

Hmm, I hadn't realized that erts files were only introduced in 29.1, so the tests are failing in 27.2 and 28.2 right now. If you have any other ideas about a nice way to test it, that would be great. Or I guess I could make the erts tests conditional on the Emacs version.

@AjaiKN
Copy link
Contributor Author

AjaiKN commented Nov 11, 2024

I guess doing the same thing manually in elisp wouldn't be too bad, so I can convert the erts files to plain elisp if you'd like the tests to continue supporting Emacs 27/28.

@davidshepherd7
Copy link
Owner

davidshepherd7 commented Nov 14, 2024

Oh huh, TIL about erts, that's interesting!

But actually I'm already using something else very similar: the ecukes code in the features/ directory. You can either migrate your tests to that or merge without the tests and I'll do it :)

(And yeah I'd like to retain support for older Emacs versions for now)

@AjaiKN
Copy link
Contributor Author

AjaiKN commented Nov 14, 2024

Ah, somehow I totally missed the features/ directory!

I'm actually not sure if I'll have the time in the near future, so merging it without the tests would be great. Thanks! (And I've copied the erts file here in case you want to reference it when adding the tests.)

@davidshepherd7 davidshepherd7 merged commit ca19beb into davidshepherd7:master Nov 14, 2024
3 checks passed
@davidshepherd7
Copy link
Owner

Thanks! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants