fix: harden windows path normalization#197
Open
bmdavis419 wants to merge 1 commit intocodex/pr-c-searchpath-files-and-dirsfrom
Open
fix: harden windows path normalization#197bmdavis419 wants to merge 1 commit intocodex/pr-c-searchpath-files-and-dirsfrom
bmdavis419 wants to merge 1 commit intocodex/pr-c-searchpath-files-and-dirsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Greptile Summary
Fixed Windows path validation to properly handle both backslash and forward slash separators. The changes ensure that Windows paths like
C:/pathare correctly validated alongsideC:\path.Key Changes:
/^[a-zA-Z]:\\/to/^[a-zA-Z]:[\\/]/to accept both separatorspath.join()andpath.dirname()for cross-platform compatibilityImpact:
LocalPathvalidation now correctly acceptsC:/path(previously rejected)SearchPathvalidation now correctly rejectsC:/pathas absolute (previously accepted due to bug)Confidence Score: 5/5
C:/pathas search paths (which should be relative), fixing a previous validation bug.Important Files Changed
path.join()andpath.dirname(), renamed variable to avoid shadowingLast reviewed commit: 6b69419