[Discover][Tabs] Unsaved changes changes#12
Closed
kertal wants to merge 61 commits into
Closed
Conversation
…nsaved changes badge, and doesn't update properly in inactive tabs
…ssion causes the session and tabs not to initialize properly
kertal
commented
Aug 18, 2025
| userId: undefined, | ||
| spaceId: undefined, | ||
| persistedDiscoverSession: undefined, | ||
| editedDiscoverSession: undefined, |
Author
There was a problem hiding this comment.
the main change, this should be updated on every relevant change on the personable part of Discover state, a.k.a Discover session. very simple change detection with this
davismcphee
force-pushed
the
discover-tabs-saving-poc
branch
from
cb1d075 to
4b41136
Compare
Author
|
not necessary because the maestro was working on it and will merge it 🥳 |
davismcphee
pushed a commit
that referenced
this pull request
May 26, 2026
## Summary Set `connect.timeout = 60s` on the undici `Agent` used by `KbnClientRequester` (https path only). ## Why elastic#268531 migrated `KbnClient` from axios to native fetch but did not override undici's 10s `connect.timeout` default. Axios had no equivalent cutoff, so FTR callers talking to a busy local Kibana started failing once that PR landed. The `kibana-streams-performance` weekly pipeline went red in builds #9, #11, #12, and #13 with: ``` ConnectTimeoutError: Connect Timeout Error (attempted address: localhost:5620, timeout: 10000ms) ``` The `10000ms` is undici's default. Bisect: build #8 last green (2026-05-11) → #9 first red (2026-05-18), with elastic#268531 in the window. ## What changed `src/platform/packages/shared/kbn-kbn-client/src/kbn_client/kbn_client_requester.ts`: one constant, one option on the https `Agent`. http branch unchanged. ## Related Regression introduced in elastic#268531. Companion streams perf PR: elastic#270636. ## Validation https://buildkite.com/elastic/kibana-streams-performance/builds/14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not to be merged ,but I was playing with the unsaved changes indication, and thing we should move forward enhancing internal state to track the persisted and the updated Discover session, which would allow us simple change dedection, and would help us to get rid of the SavedSearch container
Partly works
FYI @davismcphee @jughosta
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.