Feat/extended evaluation#22
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds extended evaluation and export capabilities to epftoolbox2 by introducing additional built-in evaluators (including a cross-model metric) and a new wide-format CSV exporter, with accompanying report/plumbing and documentation updates.
Changes:
- Extend the evaluator interface to support
compute(df, **kwargs)and pass cross-model context (model_dfs) throughEvaluationReport. - Add
RMSEEvaluatorandrMAEEvaluator(relative MAE vs. a benchmark model) and register them for YAML pipeline serialization. - Add
CsvExporter(wide-format detailed results) and update docs/reference materials accordingly.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| llms.txt | Updates evaluator/exporter reference docs and examples (new kwargs interface, new evaluators/exporter). |
| epftoolbox2/results/report.py | Passes model_dfs into evaluators; refactors grouped aggregation to support cross-model metrics; adds source_data storage. |
| epftoolbox2/pipelines/model_pipeline.py | Registers new components and passes source_data into EvaluationReport. |
| epftoolbox2/exporters/csv.py | New CsvExporter that writes a wide CSV and can join extra columns from source data. |
| epftoolbox2/exporters/init.py | Exports CsvExporter from package. |
| epftoolbox2/evaluators/rmse.py | New RMSE metric implementation. |
| epftoolbox2/evaluators/rmae.py | New relative MAE metric requiring cross-model context. |
| epftoolbox2/evaluators/mae.py | Updates MAE to accept **kwargs per new evaluator interface. |
| epftoolbox2/evaluators/base.py | Updates abstract evaluator interface to compute(df, **kwargs). |
| epftoolbox2/evaluators/init.py | Exports new evaluators from package. |
| docs/src/content/docs/reference/extending.md | Updates custom evaluator examples and documents the new evaluator interface/kwargs. |
| docs/src/content/docs/reference/api.md | Updates API reference to include new evaluators/exporter and new evaluator signature. |
| docs/src/content/docs/exporters/csv.md | New documentation page for CsvExporter. |
| docs/src/content/docs/evaluators/rmse.md | New documentation page for RMSEEvaluator. |
| docs/src/content/docs/evaluators/rmae.md | New documentation page for rMAEEvaluator. |
| docs/src/content/docs/evaluators/mae.md | Adds “See Also” links to new evaluators and extending docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.