Feat/models#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a models framework for energy price forecasting, including OLS and Lasso CV implementations with a StandardScaler for data preprocessing. However, the PR contains several critical issues that will prevent the package from being installable or functional, including missing dependencies, references to non-existent modules, and requirements for unreleased software versions.
Key changes:
- Adds BaseModel abstract class with OLSModel and LassoCVModel implementations for time-series forecasting
- Implements StandardScaler for feature and target normalization with binary feature detection
- Updates Python requirement to 3.14 and NumPy to 2.2.0 (both unreleased versions)
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Adds dependency lock file with package versions, some with future dates |
| pyproject.toml | Updates Python requirement to 3.14 and NumPy to 2.2.0 (non-existent versions) |
| .python-version | Changes Python version to 3.14t (non-existent experimental build) |
| .gitignore | Adds results/ directory to gitignore |
| epftoolbox2/models/base.py | Implements abstract base model with parallel execution, imports missing ResultStore module |
| epftoolbox2/models/ols.py | Implements OLS model using sklearn (missing dependency) |
| epftoolbox2/models/lasso.py | Implements Lasso CV model using sklearn (missing dependency) |
| epftoolbox2/models/init.py | Exports model classes |
| epftoolbox2/scalers/standard.py | Implements standard scaler with binary detection |
| epftoolbox2/scalers/init.py | Exports StandardScaler class |
| tests/scalers/test_standard.py | Comprehensive tests for StandardScaler functionality |
| tests/models/test_models.py | Comprehensive tests for model implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@copilot review and write summary