Skip to content

Feat/models#6

Merged
dawidlinek merged 14 commits into
mainfrom
feat/models
Dec 29, 2025
Merged

Feat/models#6
dawidlinek merged 14 commits into
mainfrom
feat/models

Conversation

@dawidlinek

Copy link
Copy Markdown
Owner

@copilot review and write summary

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a models framework for energy price forecasting, including OLS and Lasso CV implementations with a StandardScaler for data preprocessing. However, the PR contains several critical issues that will prevent the package from being installable or functional, including missing dependencies, references to non-existent modules, and requirements for unreleased software versions.

Key changes:

  • Adds BaseModel abstract class with OLSModel and LassoCVModel implementations for time-series forecasting
  • Implements StandardScaler for feature and target normalization with binary feature detection
  • Updates Python requirement to 3.14 and NumPy to 2.2.0 (both unreleased versions)

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
uv.lock Adds dependency lock file with package versions, some with future dates
pyproject.toml Updates Python requirement to 3.14 and NumPy to 2.2.0 (non-existent versions)
.python-version Changes Python version to 3.14t (non-existent experimental build)
.gitignore Adds results/ directory to gitignore
epftoolbox2/models/base.py Implements abstract base model with parallel execution, imports missing ResultStore module
epftoolbox2/models/ols.py Implements OLS model using sklearn (missing dependency)
epftoolbox2/models/lasso.py Implements Lasso CV model using sklearn (missing dependency)
epftoolbox2/models/init.py Exports model classes
epftoolbox2/scalers/standard.py Implements standard scaler with binary detection
epftoolbox2/scalers/init.py Exports StandardScaler class
tests/scalers/test_standard.py Comprehensive tests for StandardScaler functionality
tests/models/test_models.py Comprehensive tests for model implementations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread epftoolbox2/models/base.py Outdated
Comment thread epftoolbox2/scalers/standard.py
Comment thread epftoolbox2/scalers/standard.py Outdated
Comment thread epftoolbox2/models/base.py
Comment thread epftoolbox2/models/ols.py
Comment thread epftoolbox2/models/base.py Outdated
Comment thread epftoolbox2/models/lasso.py
Comment thread epftoolbox2/models/base.py Outdated
Comment thread epftoolbox2/scalers/standard.py
Comment thread epftoolbox2/models/base.py
@dawidlinek
dawidlinek merged commit 04de381 into main Dec 29, 2025
5 checks passed
@dawidlinek
dawidlinek deleted the feat/models branch December 29, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants