Support self-hosted Svix URL in dashboard webhooks#5079
Draft
igorvolocRC wants to merge 1 commit into
Draft
Conversation
Fixes daytonaio#5078 Signed-off-by: Igor Voloc <Igor.Voloc@RingCentral.com>
2c15a7f to
b40f732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5078
Description
This fixes Daytona dashboard webhook management for self-hosted Svix deployments.
The API already supports
SVIX_SERVER_URLfor server-side Svix calls, but the dashboard did not pass a self-hosted Svix API URL tosvix-react. In split-route deployments, browser-side webhook management could fall back to Svix Cloud instead of the configured self-hosted Svix instance.This change adds optional
SVIX_PUBLIC_SERVER_URL, defaulting toSVIX_SERVER_URL, exposes it as optionalserverUrlinWebhookAppPortalAccess, and passes it toSvixReactProviderthroughoptions.serverUrl.Generated API clients were regenerated for the public OpenAPI response schema change.
Documentation
Related Issue(s)
This PR addresses issue #5078.
Screenshots
Not applicable.
Notes
Validation completed locally:
yarn install && yarn generate:api-clientusing the Nexus npm registrynpx nx test apinpx nx build apinpx nx build dashboardyarn lint:tsSummary by cubic
Adds support for a browser-facing Svix API URL in the dashboard so self-hosted deployments use the intended endpoint instead of falling back to Svix Cloud. Addresses #5078.
New Features
SVIX_PUBLIC_SERVER_URL(defaults toSVIX_SERVER_URL) for browser access.serverUrlin WebhookAppPortalAccess.serverUrltosvix-reactviaSvixReactProvider(options.serverUrl).Migration
SVIX_PUBLIC_SERVER_URLto the public/proxied URL used by browsers; no change needed if it matchesSVIX_SERVER_URL.Written for commit a8e5450. Summary will update on new commits.