Makefile: suppress grpc generation if SUPPRESS_GENERATION is set#41
Closed
daywalker90 wants to merge 1 commit into
Closed
Makefile: suppress grpc generation if SUPPRESS_GENERATION is set#41daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
daywalker90
force-pushed
the
check-gen-updated-fix
branch
from
9a3b4e4 to
d2fa941
Compare
there is a race condition between sed rewriting node_pb2.py and node_pb2_grpc.py and the `git diff`'s from check-source Changelog-None
daywalker90
force-pushed
the
check-gen-updated-fix
branch
from
2d9601b to
2277087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-None
Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade