Feat/dbeaver/vscode#86/storybook integration #3251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychevAndrey
force-pushed
the
feat/dbeaver/vscode#86/storybook-integration
branch
2 times, most recently
from
aeaf44d to
60369a4
Compare
… values as default
…tead of many stories
SychevAndrey
force-pushed
the
feat/dbeaver/vscode#86/storybook-integration
branch
from
bbfb88d to
574f786
Compare
….com:dbeaver/cloudbeaver into feat/dbeaver/vscode#86/storybook-integration
…use it's strange that button reacts on click when in loading state, but not on hover.
Wroud
requested changes
Feb 21, 2025
Comment on lines
9
to
1
| .p { | ||
| p { |
There was a problem hiding this comment.
why has class now changed to a global style? this is CSS module we should not use global selectors like that
…n aria, icon class name
….com:dbeaver/cloudbeaver into feat/dbeaver/vscode#86/storybook-integration
…r btn loader, fix class names, updated stories
….com:dbeaver/cloudbeaver into feat/dbeaver/vscode#86/storybook-integration
Wroud
approved these changes
Feb 25, 2025
kkapper
pushed a commit
to PlaidCloud/cloudbeaver
that referenced
this pull request
Apr 18, 2025
* feat: add ui-kit package to common-react * feat: add tailwind and ladle to ui-kit, use ui-kit in ce * feat: create custom properties for button and checkbox using tailwind values as default * feat: create simple button with 2 variants * feat: create simple checkbox * refactor: update after rebase * feat: experiments with button and checkbox * feat: add buttons sizes, adjust btn loader, add interactive story instead of many stories * fix: add license * fix: a11y issues with color contrast * fix: mdx stories support * feat: experiments with icons * feat: try custom rendering * docs: add small kinda docs for button * refactor: css layers * chore: deps * chore: remove buildinfo from git * chore: remove tsbuildinfo from git * fix: vertical tab overflow * feat: use UIKit button as base for Cloudbeaver button * fix: box-sizing problems * refactor: button styles use BEM model * refactor: separate base tokens from aliases * refactor: add some defaults, write all properties in snake case * refactor: rename button classes, add ui-kit prefix * refactor: remove redundant story, omit a couple of props, add example to ladle * refactor: add general sizes tokens, update license * feat: add scaffold for input component * refactor: update deps * refactor: remove links * refactor: change props naming, add prefixes in checkbox, removes validation nodes in input * refactor: partially revert "feat: use UIKit button as base for Cloudbeaver button" to keep the old Button interface without changes Original commit SHA: 62bb1fe. * Revert "refactor: update deps" This reverts commit f7d6533. * refactor: update deps once again * refactor: rename ui-kit prefix * chore: update deps * refactor: Button Icon Interface * refactor: use JSDoc for placement comment * refactor css custom props for Button * refactor: introduce opacity custom property, fix icon margin property * fix: button text should not wrap; * fix: tailwindcss version * fix: tailwindcss version * refactor: remove checkbox styles, keep only wireframe * refactor: move input-related css variables to the dedicated folder * refactor: remove unused input props * refactor: btn loader animation * refactor: use nesting for states, refactor classnames using BEM delimiters * refactor: introduce btn-border-width prop, removed redundant btn-padding-block since we use fixed heights * refactor: input and button * fix: input * chore: deps * chore: deps * chore: add vite as dev dep * refactor: button variants * chore: yarn install * fix: loading button should not react on hover * docs: add stories about tokens * chore: remove lint command * refactor: add prefix to css variables * refactor: add base border-radius and border-width for controls * fix: don't import tailwind in style files * fix: add tailwindcss import for ladle * fix: base radius variable * refactor: rename css var * refactor: add tw prefix for tailwind classes and vars * fix: styles in easy-config * fix: after tailwind reset paddings don't in width anymore, compensate * fix: don't show outline on mouse click * refactor: change btn state classes, remove not loading for hover because it's strange that button reacts on click when in loading state, but not on hover. * fix: icons * fix: add letter-spacing to normalize to prevent tailwind reset it with inherit value * fix: welcome page selector * fix: button outline uses a variable for width, proper loading state in aria, icon class name * feat: add global styles for UI-kit ladle * docs: refactored stories composition, added stories * refactor: simplify loader, enable custom loaders, introduced token for btn loader, fix class names, updated stories * docs: add global styles for ladle * feat: use custom loader in cloudbeaver * refactor: use oklch color space for color mixing in loaders * docs: add readme * fix: tsconfig, format ladle config * docs: add short command for ladle, update readme * fix: module export * build: add vite plugin * fix: remove aria-label for loading * fix: yarn --------- Co-authored-by: mr-anton-t <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.