Selective parsing of AIRD files#217
Draft
Wuestengecko wants to merge 1 commit into
Draft
Conversation
b84eabd to
a83f146
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5791a68 to
340b149
Compare
c119e37 to
e463a28
Compare
3fd8bde to
195050f
Compare
fb5812d to
ec5ebf0
Compare
This commit changes the MelodyLoader to selectively parse only the metadata section of AIRD files, and not keep the representation data in memory all the time. This dramatically reduces the runtime memory footprint and loading times for Capella models, especially when there are lots of representations in a given model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the memory usage of various
capellambseobjects during different stages of their life cycle. As a positive side effect, this also greatly reduces the load times for models in the presence of visual representations.Here are some preliminary measurements made with our production model:
masteraird-memoryThe biggest hurdle is going to be the AIRD parser, which is currently entirely dysfunctional due to not being able to find its elements. It needs to be adjusted to work with selectively parsed AIRD files.