-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earthquake Upgrade #255
Earthquake Upgrade #255
Conversation
This is a good start. The one question I have is about 'conftest.py'... it looks like something that is complex enough that it could be subject to changing best practices over time, if not outright having issues. Is there a place where we can keep the "best one", so people adding testing to existing projects can grab it? Documentation of the process for that (packages to install, template code and where to get it) is destined for a home in our docs at some point? |
1 similar comment
This is a good start. The one question I have is about 'conftest.py'... it looks like something that is complex enough that it could be subject to changing best practices over time, if not outright having issues. Is there a place where we can keep the "best one", so people adding testing to existing projects can grab it? Documentation of the process for that (packages to install, template code and where to get it) is destined for a home in our docs at some point? |
I'm going to write a docs page for testing today. The |
It's not strictly about improving it. It's about leaving ourselves room to improve it and having it be simple for people to get the latest version. |
Got it! The obvious place to write down best practices like this is in the docs. I'll do that later today. Where else could we put it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as a first step. We still have room to improve the DB connection setup, but maybe in a separate PR
Add unit tests to the Earthquake Tracker app to demonstrate how to unit-test a DBOS app.