Skip to content

Remove semantic models tests from dbt-postgres - #1909

Merged
ash2shukla merged 4 commits into
mainfrom
ash2shukla/fix/semantic-models-test-fail-in-dbt-postgre
May 4, 2026
Merged

Remove semantic models tests from dbt-postgres#1909
ash2shukla merged 4 commits into
mainfrom
ash2shukla/fix/semantic-models-test-fail-in-dbt-postgre

Conversation

@ash2shukla

@ash2shukla ash2shukla commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

resolves #

Problem

dbt postgres integration tests fail due to mismatch of metricflow_semantic_interfaces / dbt_semantic_interfaces's TimeGranuality enum

Solution

Remove semantic models tests as it does not check anything related to dbt-postgres adapter

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ash2shukla
ash2shukla requested a review from a team as a code owner May 3, 2026 14:17
@ash2shukla ash2shukla added the skip:changelog-check Skip changelog verification in a PR label May 3, 2026
@cla-bot cla-bot Bot added the cla:yes The PR author has signed the CLA label May 3, 2026
@cla-bot
cla-bot Bot temporarily deployed to dbt-postgres May 3, 2026 14:18 Inactive
ash2shukla added 2 commits May 4, 2026 21:55
@ash2shukla
remove semantic models tests
84e4b24
@ash2shukla
Merge branch 'ash2shukla/fix/semantic-models-test-fail-in-dbt-postgre…
11c1efe 
…' of github.com:dbt-labs/dbt-adapters into ash2shukla/fix/semantic-models-test-fail-in-dbt-postgre
@ash2shukla ash2shukla changed the title remove import of a non dependent package and assert on value instead Remove semantic models tests from dbt-postgres May 4, 2026
@ash2shukla ash2shukla self-assigned this May 4, 2026
@ash2shukla
ash2shukla merged commit 98bdbf3 into main May 4, 2026
28 of 32 checks passed
@ash2shukla
ash2shukla deleted the ash2shukla/fix/semantic-models-test-fail-in-dbt-postgre branch May 4, 2026 16:56
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

✅ Promotion to stable branch was successful.

FishtownBuildBot pushed a commit that referenced this pull request May 4, 2026
@ash2shukla @web-flow
Remove semantic models tests from dbt-postgres (#1909)
7b54e17 
(cherry picked from commit 98bdbf3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@colin-k-rogers colin-k-rogers colin-k-rogers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ash2shukla ash2shukla

Labels

cla:yes The PR author has signed the CLA promote stable skip:changelog-check Skip changelog verification in a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ash2shukla @colin-k-rogers