Skip to content

Add "sample mode" test to dbt-spark #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add "sample mode" test to dbt-spark #897

wants to merge 4 commits into from

Conversation

QMalcolm
Copy link
Contributor

resolves #878

Problem

We weren't testing sample mode for spark

Solution

We now test sample mode for spark

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm added the skip:changelog-check Skip changelog verification in a PR label Mar 10, 2025
@QMalcolm QMalcolm requested a review from a team as a code owner March 10, 2025 19:38
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes The PR author has signed the CLA skip:changelog-check Skip changelog verification in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new base test case to assert that "sample mode" works
2 participants
@QMalcolm @colin-rogers-dbt