Skip to content

Conversation

@theyostalservice
Copy link
Contributor

Description

Please describe the changes made and why they were made. Link to any relevant issues or tickets.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

I'm calling this a bug fix, but it's really just a tiny amount of polish. Auto-fixing a measure into a metric would swallow explicit join_to_timespine values when they were false - this is functionally fine because that's the default value, but in practice, folks who defined the value explicitly despite it being the default probably want to keep that there for clarity/readability.

Reported internally here.

Checklist

  • Ran uv tool run ruff format --config pyproject.toml
  • If this is a bug fix:
    • Updated integration tests with bug repro
    • Linked to bug report ticket
  • ]x] Added unit tests if needed
  • Updated unit tests if needed
  • Tests passed when run locally

Copy link

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@theyostalservice theyostalservice merged commit ba6ceab into main Jan 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants