Add autofix rule to remove duplicate column definitions #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #283. Adds a new changeset rule that removes duplicate column definitions in YAML schema files, keeping the last occurrence to match dbt's runtime behavior ("only the last definition will be used"). The rule is gated behind the --behavior-change flag since removing duplicates may lose config information (descriptions, tests, masking_policy, etc.) that differs between duplicate definitions. Changes: - Add DUPLICATE_COLUMN_DEFINITION_DEPRECATION type - Add changeset_remove_duplicate_column_definitions function - Handle columns in models, seeds, snapshots, model versions, and source tables - Add comprehensive test suite (11 tests) - Update README with new deprecation coverage Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--behavior-changeflag since removing duplicates may lose config informationCloses #283
Changes
DUPLICATE_COLUMN_DEFINITION_DEPRECATIONtype todeprecations.pychangeset_remove_duplicate_column_definitionsfunction anddeduplicate_columns_listhelperbehavior_change_rules(requires--behavior-changeflag)Test plan
--behavior-changeflag🤖 Generated with Claude Code