Correctly handle agg_params in measures #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theyostalservice
force-pushed
the
patricky/handle_agg_params_correctly
branch
from
a0445cd to
587b5b1
Compare
eddowh
reviewed
Jan 18, 2026
Comment on lines
+76
to
+77
| use_discrete_percentile: True | ||
| use_approximate_percentile: False |
There was a problem hiding this comment.
YAML 1.2+ requires booleans be lowercase.
Suggested change
| use_discrete_percentile: True | |
| use_approximate_percentile: False | |
| use_discrete_percentile: true | |
| use_approximate_percentile: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an internal report for this issue. For percentile measures, there's an additional group of arguments that must be changed to fit the new YAML format when converting them to metrics, and we were not doing that.
The included tests should show the appropriate behaviors when converting the measure. In addition, I manually tested the new exception case by setting both
use_discrete_percentileanduse_approximate_percentileto true in a measure and running the script, and I saw the following error:Type of change
Checklist
uv tool run ruff format --config pyproject.toml