Skip to content

Remove check for package-level incompatible override when running pac…#342

Draft
chayac wants to merge 3 commits intomainfrom
chayac/remove-package-overrides
Draft

Remove check for package-level incompatible override when running pac…#342
chayac wants to merge 3 commits intomainfrom
chayac/remove-package-overrides

Conversation

@chayac
Copy link
Collaborator

@chayac chayac commented Mar 4, 2026

…kage upgrade

Description

Please describe the changes made and why they were made. Link to any relevant issues or tickets.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • Ran uvx ruff@0.14.14 check . --config pyproject.toml
  • Ran uvx ruff@0.14.14 format --config pyproject.toml
  • If this is a bug fix:
    • Updated integration tests with bug repro
    • Linked to bug report ticket
  • Added unit tests if needed
  • Updated unit tests if needed
  • Tests passed when run locally

@davidharting davidharting self-requested a review March 4, 2026 19:56
@davidharting
Copy link
Collaborator

davidharting commented Mar 4, 2026

In this state, does this mean we would no longer consider the explicit disallow list when upgrading packages, but we still would use it when:

  • Determining manually_verified_incompatible during parse conformance
  • Determining if a package needs to be upgraded during the packages subcommand

edit - asking bc I'm trying to get my head around what removing EXPLICIT_DISALLOW_LIST entirely would look like when the time comes!

@davidharting
Copy link
Collaborator

I think should close #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants