Refactor goldie record logic for better separation of concerns#360
Open
Refactor goldie record logic for better separation of concerns#360
Conversation
Recording the output project in compare_json_logs didn't make sense. This just moves stuff around to retain the sole purpose of compare_json_logs.
aiguofer
force-pushed
the
aiguofer/goldie_record_refactor
branch
from
c7ce052 to
ac32c06
Compare
There are changesets that change whitespace so our tests should compare output exactly to ensure all changesets, including those that only modify whitespace, produce the expected changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recording the output project in compare_json_logs didn't make sense. This moves the goldie record logic for the modified project out to retain the sole purpose of compare_json_logs.
This PR also makes the project output comparisons whitespace aware to ensure correctness for all changesets, even the ones that only modify whitespace.