This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Fix dynamic models with contract enabled#1369
Open
carolinabtt wants to merge 3 commits intodbt-labs:mainfrom
Open
Fix dynamic models with contract enabled#1369carolinabtt wants to merge 3 commits intodbt-labs:mainfrom
carolinabtt wants to merge 3 commits intodbt-labs:mainfrom
Conversation
Contributor
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-adapters#583
Problem
When a model is Contract Enforced and the sql statement contains the _dbt_max_partition variable, dbt does not declare the variable before creating the cte.
This results in the following error:
Solution
This PR fixes the bigquery__get_empty_subquery_sql macro, by checking 2 conditions:
If the conditions are met, the _dbt_max_partition is declared.