This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Open
Conversation
The insert overwrite does this, so let's copy that pattern here to keep the schemas/datasets tidy in BQ for the users
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @joshuao11 |
Contributor
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insert overwrite does this, so let's copy that pattern here to keep the schemas/datasets tidy in BQ for the users
resolves ##1389
Problem
When using a

mergestrategy with the model checking the schema (To add or replace columns):There is nothing to delete the temp table created:
Solution
We add in a step to delete and tidy up the temporary table, in the same way that is currently there for the
insert_overwritestrategy:I also checked that there was no impact on the 'ignore' strategy for
on_schema_change:There is no temporary table made here so we do not expect the DROP statement to appear:
Checklist
I ran
tox -pand everything seems to passThis change does change a macro but i'm unsure how to get feedback for Product or DX