-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Exclude environment variables when generating package lockfile #11954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tobie Tusing.
|
5b6a4a0
to
86734bc
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tobie Tusing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttusing this file is empty -- was there intended to be content in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - also fixed my commit history for the CLA bot I think, though it looks like I need to sign those commits. will address that along with any feedback!
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tobie Tusing.
|
589916d
to
5df4078
Compare
do not include env vars when hashing packages add changie
5df4078
to
32d2352
Compare
Resolves #11953
Problem
When using environment variables in git package URLs,
dbt deps
generates different package hashes on different machines even when the actual package specification is identical. This causes several problematic behaviors:Solution
Added a new optional exclude-env-vars-from-hash field to git packages that allows excluding environment variables from hash calculation while still using them for actual git operations.
GitPackage
field with YAML alias supportto_dict_for_hash()
method: Returns dictionary using unrendered values when flag is set[_create_sha1_hash()]
: Modified to use new method when available, falls back to existing behaviorBackward compatible: Existing packages continue to work unchanged (flag defaults to false)
Checklist